Removed default value from $or variable on applyFilter function #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes artisan crash when running PHP v8
|
I think the more correct way should be to remove What concerns |
This is a better fix for this PHP 8 deprecated feature: https://stackoverflow.com/a/65297280/518704 As @gruz suggests, `$or` does not need a default value as `filter_var($or, FILTER_VALIDATE_BOOLEAN)` resolves to false by default on line 130.
Author
Thanks for pointing that out @gruz. You absolutely right, the default should be removed from |
ch00n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving the $join variable blank when using PHP 8 causes an exception when running artisan.An empty array has been assigned to the variable to prevent this from happening.UPDATE: Related to this deprecated PHP feature: https://stackoverflow.com/a/65297280/518704
To ensure compatibility with PHP 8, the default value for
$orhas been removed.